Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263558: Possible NULL dereference in fast path arena free if ZapResourceArea is true #102

Closed
wants to merge 1 commit into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Apr 6, 2021

This is the backport of JDK-8263558 to JDK-16u. The original bug fix patch applied cleanly. After applying the patch to a JDK-16u repo, the fix was regression tested by running Mach5 tiers 1 and 2 on Linux, Windows, and Mac OS and Mach5 tiers 3-5 on Linux x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263558: Possible NULL dereference in fast path arena free if ZapResourceArea is true

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/102/head:pull/102
$ git checkout pull/102

Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.java.net/jdk16u pull/102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 102

View PR using the GUI difftool:
$ git pr show -t 102

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/102.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 6, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport d2c137d408b9c44f8f8d71e62dfea24a4279300e 8263558: Possible NULL dereference in fast path arena free if ZapResourceArea is true Apr 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263558: Possible NULL dereference in fast path arena free if ZapResourceArea is true

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 27c8449: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
  • 31940f1: 8263311: Watch registry changes for remote printers update instead of polling
  • 3464a0f: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed
  • 72be1e2: 8259627: Potential memory leaks in JVMTI after JDK-8227745
  • e99595b: 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die
  • 566703a: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • 484087b: 8258753: StartTlsResponse.close() hangs due to synchronization issues

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@hseigel
Copy link
Member Author

@hseigel hseigel commented Apr 6, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 6, 2021

@hseigel Since your change was applied there have been 7 commits pushed to the master branch:

  • 27c8449: 8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl
  • 31940f1: 8263311: Watch registry changes for remote printers update instead of polling
  • 3464a0f: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed
  • 72be1e2: 8259627: Potential memory leaks in JVMTI after JDK-8227745
  • e99595b: 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die
  • 566703a: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • 484087b: 8258753: StartTlsResponse.close() hangs due to synchronization issues

Your commit was automatically rebased without conflicts.

Pushed as commit 426cb6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 6, 2021

Webrevs

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant