Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262110: DST starts from incorrect time in 2038 #104

Closed
wants to merge 1 commit into from

Conversation

@kiranoracle
Copy link

@kiranoracle kiranoracle commented Apr 12, 2021

Backport to 16u as it is a long-standing bug in Calendar API. Passed regression


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8262110: DST starts from incorrect time in 2038
  • JDK-8073446: TimeZone getOffset API does not return a dst offset between years 2038-2137

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/104/head:pull/104
$ git checkout pull/104

Update a local copy of the PR:
$ git checkout pull/104
$ git pull https://git.openjdk.java.net/jdk16u pull/104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 104

View PR using the GUI difftool:
$ git pr show -t 104

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/104.diff

@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Apr 12, 2021

/issue add JDK-8073446

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 12, 2021

👋 Welcome back kravikumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7284f013ea3064b2aa643658938ccaafdfa1c885 8262110: DST starts from incorrect time in 2038 Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@kiranoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262110: DST starts from incorrect time in 2038
8073446: TimeZone getOffset API does not  return a dst offset between years 2038-2137

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@kiranoracle
Updating description of additional solved issue: 8073446: TimeZone getOffset API does not return a dst offset between years 2038-2137.

@kiranoracle
Copy link
Author

@kiranoracle kiranoracle commented Apr 12, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@kiranoracle
Your change (at version 56e1053) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 12, 2021

Webrevs

@coffeys
Copy link
Contributor

@coffeys coffeys commented Apr 12, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@coffeys @kiranoracle Pushed as commit 4f5421e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants