Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258414: OldObjectSample events too expensive #107

Closed
wants to merge 1 commit into from

Conversation

@jbachorik
Copy link

@jbachorik jbachorik commented Apr 20, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/107/head:pull/107
$ git checkout pull/107

Update a local copy of the PR:
$ git checkout pull/107
$ git pull https://git.openjdk.java.net/jdk16u pull/107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 107

View PR using the GUI difftool:
$ git pr show -t 107

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/107.diff

Co-authored-by: Florian David <florian.david@datadoghq.com>
Reviewed-by: jbachorik
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 20, 2021

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

⚠️ @jbachorik could not find any commit with hash a6cfc3f6903e52d59fe501325c2697452d2dff1d. Please update the title with the hash for an existing commit.

@jbachorik jbachorik changed the title Backport a6cfc3f6903e52d59fe501325c2697452d2dff1d Backport a9b156d358b0436584a33f71abc00c9bed9d47a3 Apr 20, 2021
@openjdk openjdk bot changed the title Backport a9b156d358b0436584a33f71abc00c9bed9d47a3 8258414: OldObjectSample events too expensive Apr 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258414: OldObjectSample events too expensive

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 71e6dab: 8225081: Remove Telia Company CA certificate expiring in April 2021
  • 8ddb1d8: 8262295: C2: Out-of-Bounds Array Load from Clone Source
  • 2826d30: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt
  • 4f5421e: 8262110: DST starts from incorrect time in 2038

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 20, 2021

Webrevs

@jbachorik
Copy link
Author

@jbachorik jbachorik commented Apr 20, 2021

/integrate

@openjdk openjdk bot closed this Apr 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@jbachorik Since your change was applied there have been 4 commits pushed to the master branch:

  • 71e6dab: 8225081: Remove Telia Company CA certificate expiring in April 2021
  • 8ddb1d8: 8262295: C2: Out-of-Bounds Array Load from Clone Source
  • 2826d30: 8264047: Duplicate global variable 'jvm' in libjavajpeg and libawt
  • 4f5421e: 8262110: DST starts from incorrect time in 2038

Your commit was automatically rebased without conflicts.

Pushed as commit 5d5b122.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant