Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265531: doc/building.md should mention homebrew install freetype #109

Closed
wants to merge 1 commit into from

Conversation

@gdams
Copy link
Contributor

@gdams gdams commented Apr 26, 2021

Backport of 8265531: doc/building.md should mention homebrew install freetype


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265531: doc/building.md should mention homebrew install freetype

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/109/head:pull/109
$ git checkout pull/109

Update a local copy of the PR:
$ git checkout pull/109
$ git pull https://git.openjdk.java.net/jdk16u pull/109/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 109

View PR using the GUI difftool:
$ git pr show -t 109

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/109.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2021

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2021

Webrevs

@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 26, 2021

/label add backport

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@gdams The label backport is not a valid label. These labels are valid:

@gdams gdams changed the title 8265531: doc/building.md should mention homebrew install freetype Backport 5aab1609b97284ccff8b7ae20a3ddcf1e29c47d7 Apr 26, 2021
@openjdk openjdk bot changed the title Backport 5aab1609b97284ccff8b7ae20a3ddcf1e29c47d7 8265531: doc/building.md should mention homebrew install freetype Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@gdams This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265531: doc/building.md should mention homebrew install freetype

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4ea26b8: 8196415: Disable SHA-1 Signed JARs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 26, 2021
@gdams
Copy link
Contributor Author

@gdams gdams commented Apr 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@gdams
Your change (at version 745586a) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Apr 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@RealCLanger @gdams Since your change was applied there has been 1 commit pushed to the master branch:

  • 4ea26b8: 8196415: Disable SHA-1 Signed JARs

Your commit was automatically rebased without conflicts.

Pushed as commit e4651f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants