Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259576: Misplaced curly brace in Matcher::find_shared_post_visit #11

Closed

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 1, 2021

Backport of JDK-8259576. Applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259576: Misplaced curly brace in Matcher::find_shared_post_visit

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/11/head:pull/11
$ git checkout pull/11

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 1, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4697cfa4b01792c04becba3632833559e4b755b7 8259576: Misplaced curly brace in Matcher::find_shared_post_visit Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259576: Misplaced curly brace in Matcher::find_shared_post_visit

Reviewed-by: vlivanov, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

Copy link

@vnkozlov vnkozlov left a comment

Trivilal.

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Feb 2, 2021

Thanks for the reviews, Vladimir and Vladimir!

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Feb 2, 2021

/integrate

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@TobiHartmann Since your change was applied there have been 2 commits pushed to the master branch:

  • 19b86c4: 8258243: C2: assert failed ("Bad derived pointer") with -XX:+VerifyRegisterAllocator
  • 62e53c8: 8258946: Fix optimization-unstable code involving signed integer overflow

Your commit was automatically rebased without conflicts.

Pushed as commit f8af3b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants