Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265239: Shenandoah: Shenandoah heap region count could be off by 1 #110

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Apr 26, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265239: Shenandoah: Shenandoah heap region count could be off by 1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/110/head:pull/110
$ git checkout pull/110

Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.java.net/jdk16u pull/110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 110

View PR using the GUI difftool:
$ git pr show -t 110

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/110.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 26, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

⚠️ @zhengyu123 could not find any commit with hash 5a526c1c5716f6d9a7fc94741bcdb2f424d342df. Please update the title with the hash for an existing commit.

@zhengyu123 zhengyu123 changed the title Backport 5a526c1c5716f6d9a7fc94741bcdb2f424d342df Backport ff5bb8cf693c58a14063a351f535e3a55e51e8db Apr 26, 2021
@openjdk openjdk bot changed the title Backport ff5bb8cf693c58a14063a351f535e3a55e51e8db 8265239: Shenandoah: Shenandoah heap region count could be off by 1 Apr 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 26, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265239: Shenandoah: Shenandoah heap region count could be off by 1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Apr 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 26, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented May 12, 2021

/integrate

@openjdk openjdk bot closed this May 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@zhengyu123 Since your change was applied there have been 6 commits pushed to the master branch:

  • 1116b75: 8265666: Enable AIX build platform to make external debug symbols
  • cb295fb: 8262899: TestRedirectLinks fails
  • 8714642: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
  • ce14719: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding
  • e4651f3: 8265531: doc/building.md should mention homebrew install freetype
  • 4ea26b8: 8196415: Disable SHA-1 Signed JARs

Your commit was automatically rebased without conflicts.

Pushed as commit 319621c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant