Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196415: Disable SHA-1 Signed JARs #111

Closed
wants to merge 1 commit into from

Conversation

@pkumaraswamy
Copy link

@pkumaraswamy pkumaraswamy commented Apr 29, 2021

This is a clean backport.
I've ran this against test suite and works fine.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/111/head:pull/111
$ git checkout pull/111

Update a local copy of the PR:
$ git checkout pull/111
$ git pull https://git.openjdk.java.net/jdk16u pull/111/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 111

View PR using the GUI difftool:
$ git pr show -t 111

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/111.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 29, 2021

👋 Welcome back pkumaraswamy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 278057756a1a79a4b030750c48b821ba9735a0f9 8196415: Disable SHA-1 Signed JARs Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@pkumaraswamy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8196415: Disable SHA-1 Signed JARs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 29, 2021

Webrevs

@pkumaraswamy
Copy link
Author

@pkumaraswamy pkumaraswamy commented Apr 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Apr 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@pkumaraswamy
Your change (at version a067c42) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

@coffeys coffeys commented Apr 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2021

@coffeys @pkumaraswamy Pushed as commit 4ea26b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants