Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16u Public archive

8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong #112

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented May 4, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/112/head:pull/112
$ git checkout pull/112

Update a local copy of the PR:
$ git checkout pull/112
$ git pull https://git.openjdk.java.net/jdk16u pull/112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 112

View PR using the GUI difftool:
$ git pr show -t 112

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/112.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 49d04586ed27fc905083d60aa68793d84824c7f3 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 4, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2021
@mlbridge
Copy link

mlbridge bot commented May 4, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels May 6, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8266288_16u branch May 6, 2021 16:49
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@TheRealMDoerr Since your change was applied there has been 1 commit pushed to the master branch:

  • ce14719: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding

Your commit was automatically rebased without conflicts.

Pushed as commit 8714642.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant