Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8266802: Shenandoah: Round up region size to page size unconditionally #120

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented May 20, 2021

I would like to backport this patch to 16u.

Without this patch, Shenandoah may not create enough regions to cover whole heap, that results some of heap memory never used.

The original patch applies cleanly to 16u and passed new test in patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266802: Shenandoah: Round up region size to page size unconditionally

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/120/head:pull/120
$ git checkout pull/120

Update a local copy of the PR:
$ git checkout pull/120
$ git pull https://git.openjdk.java.net/jdk16u pull/120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 120

View PR using the GUI difftool:
$ git pr show -t 120

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/120.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e5d3ee394ae940ee0111489e6e072f327ec29c3b 8266802: Shenandoah: Round up region size to page size unconditionally May 20, 2021
@openjdk
Copy link

openjdk bot commented May 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 20, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266802: Shenandoah: Round up region size to page size unconditionally

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 20, 2021
@mlbridge
Copy link

mlbridge bot commented May 20, 2021

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this May 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2021
@openjdk
Copy link

openjdk bot commented May 21, 2021

@zhengyu123 Since your change was applied there has been 1 commit pushed to the master branch:

  • 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option

Your commit was automatically rebased without conflicts.

Pushed as commit e0060a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant