Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented May 23, 2021

Backporting the fix for LR saving issue to jdk16u


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/121/head:pull/121
$ git checkout pull/121

Update a local copy of the PR:
$ git checkout pull/121
$ git pull https://git.openjdk.java.net/jdk16u pull/121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 121

View PR using the GUI difftool:
$ git pr show -t 121

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/121.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ca93399af103384e750dabf3abcc6e8392bcf3f4 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash May 23, 2021
@openjdk
Copy link

openjdk bot commented May 23, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 23, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • e0060a3: 8266802: Shenandoah: Round up region size to page size unconditionally
  • 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option
  • e84e185: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs
  • 860ca3f: 8260308: Update LogCompilation junit to 4.13.1
  • d917b81: 8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake
  • 319621c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
  • 1116b75: 8265666: Enable AIX build platform to make external debug symbols
  • cb295fb: 8262899: TestRedirectLinks fails
  • 8714642: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
  • ce14719: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding
  • ... and 2 more: https://git.openjdk.java.net/jdk16u/compare/cce99e57e19833e6783ba344864999ec8d475ba5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2021
@mlbridge
Copy link

mlbridge bot commented May 23, 2021

Webrevs

@VladimirKempik
Copy link
Author

/integrate

@openjdk openjdk bot closed this May 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2021
@openjdk
Copy link

openjdk bot commented May 24, 2021

@VladimirKempik Since your change was applied there have been 12 commits pushed to the master branch:

  • e0060a3: 8266802: Shenandoah: Round up region size to page size unconditionally
  • 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option
  • e84e185: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs
  • 860ca3f: 8260308: Update LogCompilation junit to 4.13.1
  • d917b81: 8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake
  • 319621c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
  • 1116b75: 8265666: Enable AIX build platform to make external debug symbols
  • cb295fb: 8262899: TestRedirectLinks fails
  • 8714642: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
  • ce14719: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding
  • ... and 2 more: https://git.openjdk.java.net/jdk16u/compare/cce99e57e19833e6783ba344864999ec8d475ba5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 410f742.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant