Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16u Public archive

8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched #122

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented May 23, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/122/head:pull/122
$ git checkout pull/122

Update a local copy of the PR:
$ git checkout pull/122
$ git pull https://git.openjdk.java.net/jdk16u pull/122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 122

View PR using the GUI difftool:
$ git pr show -t 122

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/122.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 020236cb9825bf4fa91a495a179623e3fcdc0149 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched May 23, 2021
@openjdk
Copy link

openjdk bot commented May 23, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 23, 2021
@RealCLanger
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label May 24, 2021
@openjdk
Copy link

openjdk bot commented May 24, 2021

@RealCLanger @RealCLanger this backport pull request is now marked as clean

@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2021
@mlbridge
Copy link

mlbridge bot commented May 24, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@RealCLanger This PR has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched

Reviewed-by: vkempik, mdoerr, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 6f948a7: 8267842: SIGSEGV in get_current_contended_monitor
  • 53dd617: 8260401: StackOverflowError on open WindowsPreferences
  • a680794: 8261354: SIGSEGV at MethodIteratorHost
  • 3ceb080: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 410f742: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 4, 2021
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@RealCLanger Since your change was applied there have been 5 commits pushed to the master branch:

  • 6f948a7: 8267842: SIGSEGV in get_current_contended_monitor
  • 53dd617: 8260401: StackOverflowError on open WindowsPreferences
  • a680794: 8261354: SIGSEGV at MethodIteratorHost
  • 3ceb080: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 410f742: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

Your commit was automatically rebased without conflicts.

Pushed as commit 375be17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-020236cb branch June 4, 2021 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants