Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

8267842: SIGSEGV in get_current_contended_monitor #125

Closed
wants to merge 1 commit into from
Closed

8267842: SIGSEGV in get_current_contended_monitor #125

wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 2, 2021

Fix for crashes in get_current_contended_monitor which were observed in 17 due to concurrent modification of memory locations which are not declared volatile. See bug for details.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267842: SIGSEGV in get_current_contended_monitor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/125/head:pull/125
$ git checkout pull/125

Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.java.net/jdk16u pull/125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 125

View PR using the GUI difftool:
$ git pr show -t 125

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/125.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e29005a22c7951242cf3b0d8cf2e6adc0b7b315 8267842: SIGSEGV in get_current_contended_monitor Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable backport.

@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267842: SIGSEGV in get_current_contended_monitor

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a680794: 8261354: SIGSEGV at MethodIteratorHost

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 2, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!
/integrate

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 4, 2021
@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@TheRealMDoerr Since your change was applied there have been 2 commits pushed to the master branch:

  • 53dd617: 8260401: StackOverflowError on open WindowsPreferences
  • a680794: 8261354: SIGSEGV at MethodIteratorHost

Your commit was automatically rebased without conflicts.

Pushed as commit 6f948a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8267842_get_current_contended_monitor_16u branch June 4, 2021 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants