Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211227: Inconsistent TLS protocol version in debug output #126

Closed
wants to merge 1 commit into from

Conversation

evwhelan
Copy link

@evwhelan evwhelan commented Jun 4, 2021

Hi,

Please review my backport of JDK-8211227

All testing passed.

Regards,
Evan


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8211227: Inconsistent TLS protocol version in debug output

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/126/head:pull/126
$ git checkout pull/126

Update a local copy of the PR:
$ git checkout pull/126
$ git pull https://git.openjdk.java.net/jdk16u pull/126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 126

View PR using the GUI difftool:
$ git pr show -t 126

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/126.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 4, 2021

👋 Welcome back ewhelan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a86728850e9919d2bbeeef70093adbd87bc3bb26 8211227: Inconsistent TLS protocol version in debug output Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@evwhelan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8211227: Inconsistent TLS protocol version in debug output

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 375be17: 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched
  • 6f948a7: 8267842: SIGSEGV in get_current_contended_monitor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Jun 4, 2021
@evwhelan
Copy link
Author

@evwhelan evwhelan commented Jun 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@evwhelan
Your change (at version f4333c1) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 4, 2021

Webrevs

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 4, 2021

/sponsor

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@RealCLanger @evwhelan Since your change was applied there have been 2 commits pushed to the master branch:

  • 375be17: 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched
  • 6f948a7: 8267842: SIGSEGV in get_current_contended_monitor

Your commit was automatically rebased without conflicts.

Pushed as commit 7616b2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants