8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly

[adamfarley]

Hi all,

This pull request contains a backport of commit d47a77d2 from the openjdk/jdk repository.

The commit being backported was authored by Nils Eliasson on 2 Jun 2021 and was reviewed by Roland Westrelin.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/127/head:pull/127
$ git checkout pull/127

Update a local copy of the PR:
$ git checkout pull/127
$ git pull https://git.openjdk.java.net/jdk16u pull/127/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 127

View PR using the GUI difftool:
$ git pr show -t 127

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/127.diff

[bridgekeeper]

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@adamfarley This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 7616b2c: 8211227: Inconsistent TLS protocol version in debug output
• 375be17: 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched
• 6f948a7: 8267842: SIGSEGV in get_current_contended_monitor
• 53dd617: 8260401: StackOverflowError on open WindowsPreferences
• a680794: 8261354: SIGSEGV at MethodIteratorHost
• 3ceb080: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
• 410f742: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
• e0060a3: 8266802: Shenandoah: Round up region size to page size unconditionally
• 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option
• e84e185: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs
• ... and 9 more: https://git.openjdk.java.net/jdk16u/compare/cce99e57e19833e6783ba344864999ec8d475ba5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[adamfarley]

/integrate

[openjdk]

@adamfarley
Your change (at version 10353f0) is now ready to be sponsored by a Committer.

[mlbridge]

Webrevs

• 00: Full (10353f00)

[RealCLanger]

/integrate

@adamfarley, you should have waited with that until you have a jdk16u-fix-yes label on the bug. There is no automatic checking for maintainer approval in PRs (yet?) But it's no issue in this case since you aren't commiter in jdk-updates. So we should hold back with sponsoring until approval is given. I can sponsor it then (in case it gets approved in time, monday is the last chance for 16u).

[RealCLanger]

/sponsor

[openjdk]

@RealCLanger @adamfarley Since your change was applied there have been 19 commits pushed to the master branch:

• 7616b2c: 8211227: Inconsistent TLS protocol version in debug output
• 375be17: 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched
• 6f948a7: 8267842: SIGSEGV in get_current_contended_monitor
• 53dd617: 8260401: StackOverflowError on open WindowsPreferences
• a680794: 8261354: SIGSEGV at MethodIteratorHost
• 3ceb080: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
• 410f742: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
• e0060a3: 8266802: Shenandoah: Round up region size to page size unconditionally
• 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option
• e84e185: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs
• ... and 9 more: https://git.openjdk.java.net/jdk16u/compare/cce99e57e19833e6783ba344864999ec8d475ba5...master

Your commit was automatically rebased without conflicts.

Pushed as commit d2d9533.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.