Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253368: TLS connection always receives close_notify exception #2

Closed
wants to merge 1 commit into from

Conversation

@coffeys
Copy link
Contributor

@coffeys coffeys commented Dec 24, 2020


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253368: TLS connection always receives close_notify exception

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/2/head:pull/2
$ git checkout pull/2

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 24, 2020

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a4e082e9857d6acd126fb0734583b4a1e211f9f7 8253368: TLS connection always receives close_notify exception Dec 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253368: TLS connection always receives close_notify exception

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@coffeys
Copy link
Contributor Author

@coffeys coffeys commented Dec 24, 2020

backporting 8253368 to jdk16u

@coffeys
Copy link
Contributor Author

@coffeys coffeys commented Dec 24, 2020

/integrate

@openjdk openjdk bot closed this Dec 24, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@coffeys Pushed as commit 43f4ae2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 24, 2020

Webrevs

MikaelUrankar referenced this issue in MikaelUrankar/jdk16u Jun 24, 2021
…e with

clang integrated as)

error: instruction 'addlt' can not set flags, but 's' suffix specified
__asm ("addlts  r2, openjdk#32");
       ^
<inline asm>:1:2: note: instantiated into assembly here
        addlts  r2, openjdk#32
        ^

error: invalid instruction, did you mean: ldrexh, ldrh?
__asm ("ldrgeh  r4, [r0], battleblow#2");
       ^
<inline asm>:1:2: note: instantiated into assembly here
        ldrgeh  r4, [r0], battleblow#2
        ^~~~~~

error: invalid instruction, did you mean: ldrh, ldrt?
__asm ("ldrgth  r5, [r0], battleblow#2");
       ^
<inline asm>:1:2: note: instantiated into assembly here
        ldrgth  r5, [r0], battleblow#2

Unfortunately it breaks gcc

(cherry picked from commit 8790b70f5f1e46b48a280eef2ecb9174140433a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant