Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261231: Windows IME was disabled after DnD operation #28

Closed
wants to merge 1 commit into from

Conversation

@dmarkov20
Copy link
Member

@dmarkov20 dmarkov20 commented Feb 16, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261231: Windows IME was disabled after DnD operation

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/28/head:pull/28
$ git checkout pull/28

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 16, 2021

👋 Welcome back dmarkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d6d5d9bf2f1a3343af6cf30a9d06a1f1b5f764ad 8261231: Windows IME was disabled after DnD operation Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@dmarkov20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261231: Windows IME was disabled after DnD operation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • cc3417d: 8261310: PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
  • c82a994: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • b6db9a5: 8198540: Dynalink leaks memory when generating type converters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@dmarkov20
Copy link
Member Author

@dmarkov20 dmarkov20 commented Feb 16, 2021

/integrate

@openjdk openjdk bot closed this Feb 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 16, 2021

@dmarkov20 Since your change was applied there have been 3 commits pushed to the master branch:

  • cc3417d: 8261310: PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
  • c82a994: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • b6db9a5: 8198540: Dynalink leaks memory when generating type converters

Your commit was automatically rebased without conflicts.

Pushed as commit ac08d3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dmarkov20 dmarkov20 deleted the backport-8261231 branch Feb 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 16, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant