Skip to content
This repository has been archived by the owner. It is now read-only.

8261209: isStandalone property: remove dependency on pretty-print #29

Closed
wants to merge 1 commit into from

Conversation

kiranoracle
Copy link

@kiranoracle kiranoracle commented Feb 17, 2021

Backport JDK-8261209 to 16u repo. Patch applies clean and passed regression


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261209: isStandalone property: remove dependency on pretty-print

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/29/head:pull/29
$ git checkout pull/29

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2021

👋 Welcome back kravikumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7c565f8b377bc4b61fa907b68d8c23d489df1cdc 8261209: isStandalone property: remove dependency on pretty-print Feb 17, 2021
@openjdk
Copy link

openjdk bot commented Feb 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@kiranoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261209: isStandalone property: remove dependency on pretty-print

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • ac08d3f: 8261231: Windows IME was disabled after DnD operation
  • cc3417d: 8261310: PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
  • c82a994: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • b6db9a5: 8198540: Dynalink leaks memory when generating type converters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Feb 17, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2021

Webrevs

@kiranoracle
Copy link
Author

kiranoracle commented Feb 17, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 17, 2021
@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@kiranoracle
Your change (at version 9d4c7fd) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Feb 17, 2021

/sponsor

@openjdk openjdk bot closed this Feb 17, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Feb 17, 2021
@openjdk
Copy link

openjdk bot commented Feb 17, 2021

@coffeys @kiranoracle Since your change was applied there have been 4 commits pushed to the master branch:

  • ac08d3f: 8261231: Windows IME was disabled after DnD operation
  • cc3417d: 8261310: PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
  • c82a994: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • b6db9a5: 8198540: Dynalink leaks memory when generating type converters

Your commit was automatically rebased without conflicts.

Pushed as commit 7f9d72b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated
2 participants