Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261261: The version extra fields needs to be overridable in jib-profiles.js #30

Closed
wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Feb 17, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261261: The version extra fields needs to be overridable in jib-profiles.js

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/30/head:pull/30
$ git checkout pull/30

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 17, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ab65d53edf926235231e94dcefe94becf7545d81 8261261: The version extra fields needs to be overridable in jib-profiles.js Feb 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 17, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261261: The version extra fields needs to be overridable in jib-profiles.js

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Feb 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 17, 2021

Webrevs

vidmik
vidmik approved these changes Feb 18, 2021
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Feb 19, 2021

/integrate

@openjdk openjdk bot closed this Feb 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@erikj79 Since your change was applied there have been 3 commits pushed to the master branch:

  • 1bed23a: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
  • c727528: 8253702: BigSur version number reported as 10.16, should be 11.nn
  • 9d0adb8: 8261022: Fix incorrect result of Math.abs() with char type

Your commit was automatically rebased without conflicts.

Pushed as commit cdeef37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants