Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8261752: Multiple GC test are missing memory requirements #33

Closed
wants to merge 1 commit into from

Conversation

mychris
Copy link
Contributor

@mychris mychris commented Feb 19, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261752: Multiple GC test are missing memory requirements

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/33/head:pull/33
$ git checkout pull/33

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2e18b52aed00abc18fbb1198c3818b5e0aad3ff7 8261752: Multiple GC test are missing memory requirements Feb 19, 2021
@openjdk
Copy link

openjdk bot commented Feb 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 19, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261752: Multiple GC test are missing memory requirements

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 12f505a: 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code
  • 90ac9a7: 8259679: GitHub actions should use MSVC 14.28
  • e19759b: 8260592: jpackage tests fail when Desktop is not supported
  • 247fea2: 8258534: Epsilon: clean up unused includes
  • 3266d0b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp
  • 6be71ba: 8261912: Code IfNode::fold_compares_helper more defensively
  • 692b2bf: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • d89a8cd: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
  • b5c5079: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook
  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • ... and 28 more: https://git.openjdk.java.net/jdk16u/compare/7f9d72bc866bb391caadf8760db30056bf21eb55...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 19, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 19, 2021

Webrevs

@shipilev
Copy link
Member

shipilev commented Mar 2, 2021

Note: you have requested jdk16-fix-request, not "u". I changed it for you.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport looks good. You still need to wait for jdk16u-fix-yes in JIRA.

@mychris
Copy link
Contributor Author

mychris commented Mar 3, 2021

Oh, thanks a lot for looking into this and fixing the tag, didn't notice this.

@shipilev
Copy link
Member

shipilev commented Mar 3, 2021

Please check you have the approval tag on the issue (I think you have), and if so, say /integrate, and I shall sponsor.

@mychris
Copy link
Contributor Author

mychris commented Mar 4, 2021

Yes, you are right, it got approved.
Thanks for sponsoring.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@mychris
Your change (at version 805a44c) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Mar 4, 2021

/sponsor

@openjdk openjdk bot closed this Mar 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2021
@openjdk
Copy link

openjdk bot commented Mar 4, 2021

@shipilev @mychris Since your change was applied there have been 38 commits pushed to the master branch:

  • 12f505a: 8256215: Shenandoah: re-organize saving/restoring machine state in assembler code
  • 90ac9a7: 8259679: GitHub actions should use MSVC 14.28
  • e19759b: 8260592: jpackage tests fail when Desktop is not supported
  • 247fea2: 8258534: Epsilon: clean up unused includes
  • 3266d0b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp
  • 6be71ba: 8261912: Code IfNode::fold_compares_helper more defensively
  • 692b2bf: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • d89a8cd: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
  • b5c5079: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook
  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • ... and 28 more: https://git.openjdk.java.net/jdk16u/compare/7f9d72bc866bb391caadf8760db30056bf21eb55...master

Your commit was automatically rebased without conflicts.

Pushed as commit 558a05e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants