Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS #38

Closed
wants to merge 1 commit into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Feb 22, 2021

Backport of JDK-8260349 to JDK-16u. The patch applied cleanly and was tested with tiers 1-2 on Linux, Windows, and Mac OS, and tiers 3-5 on Linux x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/38/head:pull/38
$ git checkout pull/38

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 22, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b6a736738ae025604d86924298fdd04a7851b85f 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 1dcf54f: 8262018: Wrong format in SAP copyright header of OsVersionTest
  • cdeef37: 8261261: The version extra fields needs to be overridable in jib-profiles.js
  • 1bed23a: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
  • c727528: 8253702: BigSur version number reported as 10.16, should be 11.nn
  • 9d0adb8: 8261022: Fix incorrect result of Math.abs() with char type
  • 7f9d72b: 8261209: isStandalone property: remove dependency on pretty-print
  • ac08d3f: 8261231: Windows IME was disabled after DnD operation
  • cc3417d: 8261310: PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
  • c82a994: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • b6db9a5: 8198540: Dynalink leaks memory when generating type converters
  • ... and 1 more: https://git.openjdk.java.net/jdk16u/compare/6c6c6e6784cab847976282f77df311b793d56922...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 22, 2021

Webrevs

@hseigel
Copy link
Member Author

@hseigel hseigel commented Feb 22, 2021

/integrate

@openjdk openjdk bot closed this Feb 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@hseigel Since your change was applied there have been 11 commits pushed to the master branch:

  • 1dcf54f: 8262018: Wrong format in SAP copyright header of OsVersionTest
  • cdeef37: 8261261: The version extra fields needs to be overridable in jib-profiles.js
  • 1bed23a: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
  • c727528: 8253702: BigSur version number reported as 10.16, should be 11.nn
  • 9d0adb8: 8261022: Fix incorrect result of Math.abs() with char type
  • 7f9d72b: 8261209: isStandalone property: remove dependency on pretty-print
  • ac08d3f: 8261231: Windows IME was disabled after DnD operation
  • cc3417d: 8261310: PPC64 Zero build fails with 'VMError::controlled_crash(int)::FunctionDescriptor functionDescriptor' has incomplete type and cannot be defined
  • c82a994: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • b6db9a5: 8198540: Dynalink leaks memory when generating type converters
  • ... and 1 more: https://git.openjdk.java.net/jdk16u/compare/6c6c6e6784cab847976282f77df311b793d56922...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5828fc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant