Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226810: Failed to launch JVM because of NullPointerException occured on System.props #4

Closed
wants to merge 1 commit into from

Conversation

evwhelan
Copy link

@evwhelan evwhelan commented Jan 15, 2021

This simple backport enables the GB18030 charset to be built into java.base on Windows.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8226810: Failed to launch JVM because of NullPointerException occured on System.props

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/4/head:pull/4
$ git checkout pull/4

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 15, 2021

👋 Welcome back ewhelan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

⚠️ @evwhelan could not find any commit with hash 5d3f0c51d6bd880b7533c9c3e1fdf446d2d09483. Please update the title with the hash for an existing commit.

@evwhelan evwhelan changed the title Backport 5d3f0c51d6bd880b7533c9c3e1fdf446d2d09483 Backport 5f7ccce0c03b2b814c0bae132d359d9903708496 Jan 15, 2021
@openjdk openjdk bot changed the title Backport 5f7ccce0c03b2b814c0bae132d359d9903708496 8226810: Failed to launch JVM because of NullPointerException occured on System.props Jan 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@evwhelan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8226810: Failed to launch JVM because of NullPointerException occured on System.props

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Jan 15, 2021
@evwhelan
Copy link
Author

@evwhelan evwhelan commented Jan 15, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@evwhelan
Your change (at version fe8cc9a) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2021

Webrevs

@evwhelan
Copy link
Author

@evwhelan evwhelan commented Jan 15, 2021

This change is pending approval. Please hold off sponsoring until such time

@evwhelan
Copy link
Author

@evwhelan evwhelan commented Jan 25, 2021

Approval granted for this change, now ready for sponsor

@coffeys
Copy link
Contributor

@coffeys coffeys commented Jan 25, 2021

/sponsor

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@coffeys @evwhelan Since your change was applied there have been 77 commits pushed to the master branch:

  • 8c39029: Merge
  • 0120510: 8259732: JDK 16 L10n resource file update - msg drop 10
  • f7b96d3: 8259796: timed CompletableFuture.get may swallow InterruptedException
  • bb0821e: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
  • cd25bf2: 8259574: SIGSEGV in BFSClosure::closure_impl
  • d5ca3b3: 8259641: C2: assert(early->dominates(LCA)) failed: early is high enough
  • e85892b: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
  • 4307fa6: 8253505: JFR: onFlush invoked out of order with a sorted event stream
  • 0148adf: 8255120: C2: assert(outer->outcnt() >= phis + 2 && outer->outcnt() <= phis + 2 + stores + 1) failed: only phis
  • 5926d75: 8259719: ProblemList runtime/cds/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java on Windows
  • ... and 67 more: https://git.openjdk.java.net/jdk16u/compare/bf90c47566e993eb75fe259011802529ea6e570b...master

Your commit was automatically rebased without conflicts.

Pushed as commit e9dae4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants