Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234 #43

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Feb 25, 2021

The original bug fix patch applied cleanly and included regression tests. After applying the patch to a JDK-16u repo, the fix was regression tested by running Mach5 tiers 1 and 2 on Linux, Windows, and Mac OS, and running tiers 3-5 on Linux x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234
  • JDK-8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/43/head:pull/43
$ git checkout pull/43

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 25, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 712014c5956cf74982531d212b03460843e4e5b6 8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234 Feb 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Feb 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 25, 2021

Webrevs

@hseigel
Copy link
Member Author

@hseigel hseigel commented Feb 25, 2021

/issue add JDK-8259446

@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

@hseigel
Adding additional issue to issue list: 8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty.

@hseigel
Copy link
Member Author

@hseigel hseigel commented Feb 25, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

@hseigel This PR has not yet been marked as ready for integration.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258077: Using -Xcheck:jni can lead to a double-free after JDK-8193234
8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9fa0e03: 8261334: NMT: tuning statistic shows incorrect hash distribution
  • 262c989: 8260029: aarch64: fix typo in verify_oop_array

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 25, 2021
@hseigel
Copy link
Member Author

@hseigel hseigel commented Feb 25, 2021

Thanks Coleen, for the review!

/integrate

@openjdk openjdk bot closed this Feb 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 25, 2021

@hseigel Since your change was applied there have been 2 commits pushed to the master branch:

  • 9fa0e03: 8261334: NMT: tuning statistic shows incorrect hash distribution
  • 262c989: 8260029: aarch64: fix typo in verify_oop_array

Your commit was automatically rebased without conflicts.

Pushed as commit b7b2f61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Feb 25, 2021

Thanks for doing the backport Harold!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants