Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

8261251: Shenandoah: Use object size for full GC humongous compaction #55

Closed
wants to merge 1 commit into from
Closed

8261251: Shenandoah: Use object size for full GC humongous compaction #55

wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 1, 2021

This fixes a minor performance issue in Shenandoah (which becomes asserted in later projects, i.e. Loom).

Additional testing:

  • hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261251: Shenandoah: Use object size for full GC humongous compaction

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/55/head:pull/55
$ git checkout pull/55

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport deb0544ff330fadc5aac0378766bcd36c220d7e2 8261251: Shenandoah: Use object size for full GC humongous compaction Mar 1, 2021
@openjdk
Copy link

openjdk bot commented Mar 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 1, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 1, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261251: Shenandoah: Use object size for full GC humongous compaction

Reviewed-by: zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 1, 2021
@shipilev
Copy link
Member Author

shipilev commented Mar 2, 2021

/integrate

@openjdk openjdk bot closed this Mar 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@shipilev Since your change was applied there have been 6 commits pushed to the master branch:

  • 39fb8e5: 8261413: Shenandoah: Disable class-unloading in I-U mode
  • b9582bf: 8260048: Shenandoah: ShenandoahMarkingContext asserts are unnecessary
  • f081554: 8259580: Shenandoah: uninitialized label in VerifyThreadGCState
  • 395ab59: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers
  • cec5816: 8259954: gc/shenandoah/mxbeans tests fail with -Xcomp
  • f36b10a: 8261170: Upgrade to freetype 2.10.4

Your commit was automatically rebased without conflicts.

Pushed as commit 101e742.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8261251-sh-fullgc-objsize branch March 9, 2021 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants