Skip to content
This repository has been archived by the owner. It is now read-only.

8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings #60

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 2, 2021

This stabilizes the test.

Additional testing:

  • Linux x86_64 fastdebug, affected tests with/without -XX:-CompactStrings

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/60/head:pull/60
$ git checkout pull/60

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9f0f0c9870b9e09aff4dca20bd1404a1872ac566 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 2, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Mar 2, 2021

/integrate

@openjdk openjdk bot closed this Mar 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@shipilev Since your change was applied there have been 2 commits pushed to the master branch:

  • 466eff3: 8259849: Shenandoah: Rename store-val to IU-barrier
  • 09855d7: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java

Your commit was automatically rebased without conflicts.

Pushed as commit 6de0fae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8260933-cds-compact-strings branch Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant