Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings #61

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 2, 2021

This stabilizes the test.

Additional testing:

  • Linux x86_64 fastdebug, affected test, -XX:-CompactStrings
  • Linux x86_64 fastdebug, affected test, -XX:+CompactStrings

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/61/head:pull/61
$ git checkout pull/61

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 2, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ad54d8dd832b22485d7ac45958cc4c9bfd70fbd2 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings Mar 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 2, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Mar 2, 2021

/integrate

@openjdk openjdk bot closed this Mar 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@shipilev Since your change was applied there have been 3 commits pushed to the master branch:

  • 6de0fae: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
  • 466eff3: 8259849: Shenandoah: Rename store-val to IU-barrier
  • 09855d7: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java

Your commit was automatically rebased without conflicts.

Pushed as commit 802c6ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8260934-cs-hugecapacity branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant