Skip to content
This repository has been archived by the owner. It is now read-only.

8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp #64

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 2, 2021

This improves hs_errs after JDK 16 change, which might be confusing (compress klass ptrs are enabled, when hs_err is pointing out in only one place in heap info).

Additional testing:

  • Linux x86_64 fastdebug tier1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/64/head:pull/64
$ git checkout pull/64

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 2, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a03e22bb14e0873a599320676fc9d2128a1e23cb 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp Mar 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 2, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 2, 2021

Webrevs

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Mar 2, 2021

LGTM.
May be just me but it was not immediately clear that this is a backport to 16. I wondered why the issue was already marked as resolved.
..Thomas

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Mar 3, 2021

/integrate

@openjdk openjdk bot closed this Mar 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@shipilev Since your change was applied there have been 13 commits pushed to the master branch:

  • 6be71ba: 8261912: Code IfNode::fold_compares_helper more defensively
  • 692b2bf: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • d89a8cd: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
  • b5c5079: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook
  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 3754490: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 81395c4: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • bb285ce: 8259392: Zero error reporting is broken after JDK-8255711
  • 6198e0c: 8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false
  • 802c6ad: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • ... and 3 more: https://git.openjdk.java.net/jdk16u/compare/101e7429aebf41fc358b1deeda1120024a0b1cd5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3266d0b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8253910-ccp-co branch Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants