Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261860: Crash caused by lambda proxy class loaded in Shutdown hook #67

Closed
wants to merge 1 commit into from

Conversation

@calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Mar 2, 2021

Backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261860: Crash caused by lambda proxy class loaded in Shutdown hook ⚠️ Issue is not open.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/67/head:pull/67
$ git checkout pull/67

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 2, 2021

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@calvinccheung calvinccheung marked this pull request as ready for review Mar 2, 2021
@openjdk openjdk bot added the rfr label Mar 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 2, 2021

Webrevs

Loading

yminqi
yminqi approved these changes Mar 2, 2021
Copy link
Contributor

@yminqi yminqi left a comment

LGTM.

Loading

iklam
iklam approved these changes Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261860: Crash caused by lambda proxy class loaded in Shutdown hook

Reviewed-by: minqi, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 3754490: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 81395c4: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • bb285ce: 8259392: Zero error reporting is broken after JDK-8255711
  • 6198e0c: 8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false
  • 802c6ad: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • 6de0fae: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
  • 466eff3: 8259849: Shenandoah: Rename store-val to IU-barrier
  • 09855d7: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java
  • 101e742: 8261251: Shenandoah: Use object size for full GC humongous compaction
  • ... and 6 more: https://git.openjdk.java.net/jdk16u/compare/2a9780abd5b1eca34ce3fb167fc042f308e8c28b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Mar 3, 2021
@calvinccheung
Copy link
Member Author

@calvinccheung calvinccheung commented Mar 3, 2021

/integrate

Loading

@openjdk openjdk bot closed this Mar 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@calvinccheung Since your change was applied there have been 16 commits pushed to the master branch:

  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 3754490: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 81395c4: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • bb285ce: 8259392: Zero error reporting is broken after JDK-8255711
  • 6198e0c: 8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false
  • 802c6ad: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • 6de0fae: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
  • 466eff3: 8259849: Shenandoah: Rename store-val to IU-barrier
  • 09855d7: 8251944: Add Shenandoah test config to compiler/gcbarriers/UnsafeIntrinsicsTest.java
  • 101e742: 8261251: Shenandoah: Use object size for full GC humongous compaction
  • ... and 6 more: https://git.openjdk.java.net/jdk16u/compare/2a9780abd5b1eca34ce3fb167fc042f308e8c28b...master

Your commit was automatically rebased without conflicts.

Pushed as commit b5c5079.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@calvinccheung calvinccheung deleted the 8261860 branch Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants