Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8260592: jpackage tests fail when Desktop is not supported #70

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 2, 2021

This unbreaks jpackage tests on x86_32 cross-compiled builds.

Additional testing:

  • Linux x86_32 tools/jpackage (pass cleanly)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260592: jpackage tests fail when Desktop is not supported

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/70/head:pull/70
$ git checkout pull/70

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 24a262124f507759d72cddc0d1371b31ef1661cf 8260592: jpackage tests fail when Desktop is not supported Mar 2, 2021
@openjdk
Copy link

openjdk bot commented Mar 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 2, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260592: jpackage tests fail when Desktop is not supported

Reviewed-by: asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 3754490: 8252883: AccessDeniedException caused by delayed file deletion on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 2, 2021

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Mar 3, 2021

/integrate

@openjdk openjdk bot closed this Mar 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2021
@openjdk
Copy link

openjdk bot commented Mar 3, 2021

@shipilev Since your change was applied there have been 8 commits pushed to the master branch:

  • 247fea2: 8258534: Epsilon: clean up unused includes
  • 3266d0b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp
  • 6be71ba: 8261912: Code IfNode::fold_compares_helper more defensively
  • 692b2bf: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • d89a8cd: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
  • b5c5079: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook
  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 3754490: 8252883: AccessDeniedException caused by delayed file deletion on Windows

Your commit was automatically rebased without conflicts.

Pushed as commit e19759b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8260592-jpackage-tests branch Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants