Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257746: Regression introduced with JDK-8250984 - memory might be null in some machines #73

Closed
wants to merge 1 commit into from

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Mar 3, 2021

The patch for this fix applied cleanly. The change was regression tested with tiers 1 and 2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/73/head:pull/73
$ git checkout pull/73

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 3, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport abc4300de9c7a298c359fb585d3b0570a98df5cb 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257746: Regression introduced with JDK-8250984 - memory might be null in some machines

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • d89a8cd: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
  • b5c5079: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook
  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 3754490: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 81395c4: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • bb285ce: 8259392: Zero error reporting is broken after JDK-8255711
  • 6198e0c: 8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false
  • 802c6ad: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • 6de0fae: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
  • 466eff3: 8259849: Shenandoah: Rename store-val to IU-barrier
  • ... and 11 more: https://git.openjdk.java.net/jdk16u/compare/9fa0e03de689ef36c8f678ec43a0794f3b94fda5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@hseigel
Copy link
Member Author

@hseigel hseigel commented Mar 3, 2021

/integrate

@openjdk openjdk bot closed this Mar 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2021

@hseigel Since your change was applied there have been 21 commits pushed to the master branch:

  • d89a8cd: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
  • b5c5079: 8261860: Crash caused by lambda proxy class loaded in Shutdown hook
  • b5ea908: 8261758: [TESTBUG] gc/g1/TestGCLogMessages.java fails if ergonomics detect too small InitialHeapSize
  • 3754490: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 81395c4: 8259231: Epsilon: improve performance under contention during virtual space expansion
  • bb285ce: 8259392: Zero error reporting is broken after JDK-8255711
  • 6198e0c: 8259451: Zero: skip serviceability/sa tests, set vm.hasSA to false
  • 802c6ad: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • 6de0fae: 8260933: runtime/cds/serviceability/ReplaceCriticalClassesForSubgraphs.java fails without CompactStrings
  • 466eff3: 8259849: Shenandoah: Rename store-val to IU-barrier
  • ... and 11 more: https://git.openjdk.java.net/jdk16u/compare/9fa0e03de689ef36c8f678ec43a0794f3b94fda5...master

Your commit was automatically rebased without conflicts.

Pushed as commit 692b2bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 3, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant