Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload #77

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 9, 2021

JDK-8261912 provided the release-mode bailout, and this issue is supposed to fix the corner case in debug-mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/77/head:pull/77
$ git checkout pull/77

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 9, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 20c93b3b901806cd9d691d75c8f30398c41fec34 8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload Mar 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 9, 2021

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 10, 2021

Mailing list message from Vladimir Kozlov on jdk-updates-dev:

It looks like backport was applied cleanly. Reviewed.

Thanks,
Vladimir K

On 3/9/21 5:21 AM, Aleksey Shipilev wrote:

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Mar 15, 2021

/integrate

@openjdk openjdk bot closed this Mar 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@shipilev Pushed as commit 6905591.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8261914 branch Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant