8260401: StackOverflowError on open WindowsPreferences

[evwhelan]

Hi,

Please review this backport which prevents StackOverflowError occurring on Windows.

This occurs when users have incorrect registry access.

Regards,
Evan

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260401: StackOverflowError on open WindowsPreferences

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/78/head:pull/78
$ git checkout pull/78

Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.java.net/jdk16u pull/78/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 78

View PR using the GUI difftool:
$ git pr show -t 78

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/78.diff

[bridgekeeper]

👋 Welcome back ewhelan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@evwhelan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260401: StackOverflowError on open WindowsPreferences

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• a680794: 8261354: SIGSEGV at MethodIteratorHost
• 3ceb080: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
• 410f742: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
• e0060a3: 8266802: Shenandoah: Round up region size to page size unconditionally
• 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option
• e84e185: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs
• 860ca3f: 8260308: Update LogCompilation junit to 4.13.1
• d917b81: 8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake
• 319621c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
• 1116b75: 8265666: Enable AIX build platform to make external debug symbols
• ... and 54 more: https://git.openjdk.java.net/jdk16u/compare/e3e74008e8bbbbad2034931a4a0b5b55099e0138...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (a523c95)

[RealCLanger]

@evwhelan, will you still integrate this? I can then sponsor it...

[evwhelan]

@RealCLanger thanks for getting this back on my radar!

[evwhelan]

/integrate

[openjdk]

@evwhelan
Your change (at version a523c95) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

@RealCLanger @evwhelan Since your change was applied there have been 64 commits pushed to the master branch:

• a680794: 8261354: SIGSEGV at MethodIteratorHost
• 3ceb080: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
• 410f742: 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash
• e0060a3: 8266802: Shenandoah: Round up region size to page size unconditionally
• 5311c4d: 8267345: VM crashes during dumping classlist with -Xshare:dump option
• e84e185: 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs
• 860ca3f: 8260308: Update LogCompilation junit to 4.13.1
• d917b81: 8267117: sun/hotspot/whitebox/CPUInfoTest.java fails on Ice Lake
• 319621c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
• 1116b75: 8265666: Enable AIX build platform to make external debug symbols
• ... and 54 more: https://git.openjdk.java.net/jdk16u/compare/e3e74008e8bbbbad2034931a4a0b5b55099e0138...master

Your commit was automatically rebased without conflicts.

Pushed as commit 53dd617.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.