Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator #79

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 11, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/79/head:pull/79
$ git checkout pull/79

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 11, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9b4f033ddfb2e7ea36ecdf2f076fc374fe54cac 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator Mar 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 11, 2021

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

LGTM

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Mar 22, 2021

/integrate

@openjdk openjdk bot closed this Mar 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@RealCLanger Since your change was applied there have been 9 commits pushed to the master branch:

  • b64af94: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
  • c1ef397: 8260236: better init AnnotationCollector _contended_group
  • 2c6b47c: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 71102e7: 8263136: C4530 was reported from VS 2019 at access bridge
  • db7b1c9: 8263430: Uninitialized Method* variables after JDK-8233913
  • 0aeeebb: 8263557: Possible NULL dereference in Arena::destruct_contents()
  • 7ba457a: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 86a970d: 8262446: DragAndDrop hangs on Windows
  • 6905591: 8261914: IfNode::fold_compares_helper faces non-canonicalized bool when running JRuby JSON workload

Your commit was automatically rebased without conflicts.

Pushed as commit 34ecf72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the 8263069-test-exclusions branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants