Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263030: Remove Shenandoah leftovers from ReferenceProcessor #81

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 15, 2021

Shenandoah is no longer using the shared ReferenceProcessor. We can remove remaining Shenandoah leftovers there.

Additional testing:

  • Linux x86_64 fastdebug, hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263030: Remove Shenandoah leftovers from ReferenceProcessor

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/81/head:pull/81
$ git checkout pull/81

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 15, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport ef5e13d263b6d4aaa50e777f7a3fc818293126c8 8263030: Remove Shenandoah leftovers from ReferenceProcessor Mar 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Mar 15, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263030: Remove Shenandoah leftovers from ReferenceProcessor

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 15, 2021

Webrevs

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Mar 22, 2021

/integrate

Loading

@openjdk openjdk bot closed this Mar 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@shipilev Since your change was applied there have been 5 commits pushed to the master branch:

  • 71102e7: 8263136: C4530 was reported from VS 2019 at access bridge
  • db7b1c9: 8263430: Uninitialized Method* variables after JDK-8233913
  • 0aeeebb: 8263557: Possible NULL dereference in Arena::destruct_contents()
  • 7ba457a: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 86a970d: 8262446: DragAndDrop hangs on Windows

Your commit was automatically rebased without conflicts.

Pushed as commit 2c6b47c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant