Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8260236: better init AnnotationCollector _contended_group #83

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Mar 15, 2021

This eliminates a potential source of bugs, and keeps codebases in sync (I see 11.0.12-oracle). Patch apples to 11u cleanly, passes tier{1,2}.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260236: better init AnnotationCollector _contended_group

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk16u pull/83/head:pull/83
$ git checkout pull/83

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fd2641ed36c8cdb59c33675bd9ed909b47cd002e 8260236: better init AnnotationCollector _contended_group Mar 15, 2021
@openjdk
Copy link

openjdk bot commented Mar 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 15, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260236: better init AnnotationCollector _contended_group

Reviewed-by: hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 86a970d: 8262446: DragAndDrop hangs on Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shipilev
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2021
@openjdk
Copy link

openjdk bot commented Mar 22, 2021

@shipilev Since your change was applied there have been 6 commits pushed to the master branch:

  • 2c6b47c: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 71102e7: 8263136: C4530 was reported from VS 2019 at access bridge
  • db7b1c9: 8263430: Uninitialized Method* variables after JDK-8233913
  • 0aeeebb: 8263557: Possible NULL dereference in Arena::destruct_contents()
  • 7ba457a: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 86a970d: 8262446: DragAndDrop hangs on Windows

Your commit was automatically rebased without conflicts.

Pushed as commit c1ef397.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants