Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259627: Potential memory leaks in JVMTI after JDK-8227745 #87

Conversation

reinrich
Copy link
Contributor

@reinrich reinrich commented Mar 18, 2021

This is the jdk16u backport of the fix for JDK-8259627. The original patch applies cleanly without modification.

The fix passed our CI testing: JCK and JTREG, also in Xcomp mode, SPECjvm2008, SPECjbb2015, Renaissance Suite,
SAP specific tests with fastdebug and release builds on all platforms


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259627: Potential memory leaks in JVMTI after JDK-8227745

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/87/head:pull/87
$ git checkout pull/87

To update a local copy of the PR:
$ git checkout pull/87
$ git pull https://git.openjdk.java.net/jdk16u pull/87/head

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2021

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6d4a593f8d139f633e4942518059f1e2c0ab0384 8259627: Potential memory leaks in JVMTI after JDK-8227745 Mar 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 22, 2021

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259627: Potential memory leaks in JVMTI after JDK-8227745

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 75ed034: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true
  • 62adf83: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
  • 34ecf72: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator
  • b64af94: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
  • c1ef397: 8260236: better init AnnotationCollector _contended_group
  • 2c6b47c: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 71102e7: 8263136: C4530 was reported from VS 2019 at access bridge
  • db7b1c9: 8263430: Uninitialized Method* variables after JDK-8233913
  • 0aeeebb: 8263557: Possible NULL dereference in Arena::destruct_contents()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 22, 2021
@reinrich reinrich marked this pull request as ready for review Mar 23, 2021
@openjdk openjdk bot added the rfr label Mar 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 23, 2021

Webrevs

@reinrich
Copy link
Contributor Author

@reinrich reinrich commented Mar 31, 2021

/integrate

@openjdk openjdk bot closed this Mar 31, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2021

@reinrich Since your change was applied there have been 13 commits pushed to the master branch:

  • e99595b: 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die
  • 566703a: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • 484087b: 8258753: StartTlsResponse.close() hangs due to synchronization issues
  • 5375fda: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton
  • 75ed034: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true
  • 62adf83: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
  • 34ecf72: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator
  • b64af94: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
  • c1ef397: 8260236: better init AnnotationCollector _contended_group
  • 2c6b47c: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • ... and 3 more: https://git.openjdk.java.net/jdk16u/compare/7ba457ab4b040ac2a9937c1550a6af8ac872eb5e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 72be1e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant