Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
/ jdk16u Public archive

8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl #93

Closed
wants to merge 2 commits into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Mar 26, 2021

Please review this backport to 16u. The backport is clean, except for syntax-only
changes to catch expressions, and one context change in SSLSocketImpl.java.

Original JBS: https://bugs.openjdk.java.net/browse/JDK-8259662
Original commit: openjdk/jdk@63f8fc87


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl ⚠️ Issue is not open.

Download

To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/93/head:pull/93
$ git checkout pull/93

To update a local copy of the PR:
$ git checkout pull/93
$ git pull https://git.openjdk.java.net/jdk16u pull/93/head

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 26, 2021

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2021
@phohensee
Copy link
Member Author

/issue add 8259662

@openjdk
Copy link

openjdk bot commented Mar 26, 2021

@phohensee This issue is referenced in the PR title - it will now be updated.

@phohensee
Copy link
Member Author

/cc jdk-updates-dev

@openjdk
Copy link

openjdk bot commented Mar 26, 2021

@phohensee The label jdk-updates is not a valid label. These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Mar 26, 2021

Webrevs

@RealCLanger
Copy link
Contributor

@phohensee, did you create the backport via git backport --from=openjdk/jdk 63f8fc87cdf3edb828474bb4954b76721ba8f9e5? Or the manual way described in https://wiki.openjdk.java.net/display/SKARA/Backports#Backports-CLI ?

For some reason the bots don't recognize it as a backport...

You also need to request push approval via jdk16u-fix-request label in https://bugs.openjdk.java.net/browse/JDK-8259662

@phohensee
Copy link
Member Author

I did it manually (see my plaintive question!). Shall I close this PR and redo it using git backport?

@RealCLanger
Copy link
Contributor

I did it manually (see my plaintive question!). Shall I close this PR and redo it using git backport?

Hm, I think the commit should have had the message 'Backport 63f8fc87cdf3edb828474bb4954b76721ba8f9e5'. And probably the PR title as well. Then the bots would have recognized the backport. Maybe a force push of a squashed commit with this message would help. Or do it in another PR...

@phohensee
Copy link
Member Author

Closing in favor of a PR using git backport.

@phohensee phohensee closed this Mar 26, 2021
@phohensee phohensee deleted the 8259662 branch March 26, 2021 18:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants