-
Notifications
You must be signed in to change notification settings - Fork 57
8259662: Don't wrap SocketExceptions into SSLExceptions in SSLSocketImpl #93
Conversation
👋 Welcome back phh! A progress list of the required criteria for merging this PR into |
/issue add 8259662 |
@phohensee This issue is referenced in the PR title - it will now be updated. |
/cc jdk-updates-dev |
@phohensee The label |
Webrevs
|
@phohensee, did you create the backport via git backport --from=openjdk/jdk 63f8fc87cdf3edb828474bb4954b76721ba8f9e5? Or the manual way described in https://wiki.openjdk.java.net/display/SKARA/Backports#Backports-CLI ? For some reason the bots don't recognize it as a backport... You also need to request push approval via jdk16u-fix-request label in https://bugs.openjdk.java.net/browse/JDK-8259662 |
I did it manually (see my plaintive question!). Shall I close this PR and redo it using git backport? |
Hm, I think the commit should have had the message 'Backport 63f8fc87cdf3edb828474bb4954b76721ba8f9e5'. And probably the PR title as well. Then the bots would have recognized the backport. Maybe a force push of a squashed commit with this message would help. Or do it in another PR... |
Closing in favor of a PR using git backport. |
Please review this backport to 16u. The backport is clean, except for syntax-only
changes to catch expressions, and one context change in SSLSocketImpl.java.
Original JBS: https://bugs.openjdk.java.net/browse/JDK-8259662
Original commit: openjdk/jdk@63f8fc87
Progress
Issue
Download
To checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/93/head:pull/93
$ git checkout pull/93
To update a local copy of the PR:
$ git checkout pull/93
$ git pull https://git.openjdk.java.net/jdk16u pull/93/head