Skip to content
This repository was archived by the owner on Sep 2, 2022. It is now read-only.

Conversation

@hseigel
Copy link
Member

@hseigel hseigel commented Mar 30, 2021

Please review this backport of JDK-8263564 to JDK-16u. The original bug fix patch applied cleanly except for files os_linux.cpp and os_posix.cpp. But, the resulting hand merge resulted in code very similar to the original fix. After applying the patch to a JDK-16u repo and modifying the appropriate os_<..>.cpp files, the fix was regression tested by running Mach5 tiers 1 and 2 on Linux, Windows, and Mac OS, and running tiers 3-5 on Linux x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/97/head:pull/97
$ git checkout pull/97

Update a local copy of the PR:
$ git checkout pull/97
$ git pull https://git.openjdk.java.net/jdk16u pull/97/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 97

View PR using the GUI difftool:
$ git pr show -t 97

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/97.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 554dd29fb67b9a25ad161920b57e238c06024938 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die Mar 30, 2021
@openjdk
Copy link

openjdk bot commented Mar 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 30, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an accurate backport.

Thanks,
David

@openjdk
Copy link

openjdk bot commented Mar 30, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 566703a: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • 484087b: 8258753: StartTlsResponse.close() hangs due to synchronization issues
  • 5375fda: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton
  • 75ed034: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true
  • 62adf83: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
  • 34ecf72: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator
  • b64af94: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
  • c1ef397: 8260236: better init AnnotationCollector _contended_group
  • 2c6b47c: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 71102e7: 8263136: C4530 was reported from VS 2019 at access bridge

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2021
@hseigel
Copy link
Member Author

hseigel commented Mar 31, 2021

Thanks David for reviewing this!

/integrate

@openjdk openjdk bot closed this Mar 31, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@hseigel Since your change was applied there have been 10 commits pushed to the master branch:

  • 566703a: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • 484087b: 8258753: StartTlsResponse.close() hangs due to synchronization issues
  • 5375fda: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton
  • 75ed034: 8263587: C2: JVMS not cloned when needs_clone_jvms() is true
  • 62adf83: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
  • 34ecf72: 8263069: Exclude some failing tests from security/infra/java/security/cert/CertPathValidator
  • b64af94: 8261505: Test test/hotspot/jtreg/gc/parallel/TestDynShrinkHeap.java killed by Linux OOM Killer
  • c1ef397: 8260236: better init AnnotationCollector _contended_group
  • 2c6b47c: 8263030: Remove Shenandoah leftovers from ReferenceProcessor
  • 71102e7: 8263136: C4530 was reported from VS 2019 at access bridge

Your commit was automatically rebased without conflicts.

Pushed as commit e99595b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants