-
Notifications
You must be signed in to change notification settings - Fork 54
8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die #97
Conversation
|
👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an accurate backport.
Thanks,
David
|
@hseigel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Thanks David for reviewing this! /integrate |
|
@hseigel Since your change was applied there have been 10 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e99595b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this backport of JDK-8263564 to JDK-16u. The original bug fix patch applied cleanly except for files os_linux.cpp and os_posix.cpp. But, the resulting hand merge resulted in code very similar to the original fix. After applying the patch to a JDK-16u repo and modifying the appropriate os_<..>.cpp files, the fix was regression tested by running Mach5 tiers 1 and 2 on Linux, Windows, and Mac OS, and running tiers 3-5 on Linux x64.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/97/head:pull/97$ git checkout pull/97Update a local copy of the PR:
$ git checkout pull/97$ git pull https://git.openjdk.java.net/jdk16u pull/97/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 97View PR using the GUI difftool:
$ git pr show -t 97Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/97.diff