Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed #98

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Mar 31, 2021

The patch for this JDK-16u backport of JDK-8261916 applied cleanly and was regression tested with Mach5 tiers 1-2 on Linux, Mac OS, and Windows, and Mach5 tiers 3-5 on Linux x64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/98/head:pull/98
$ git checkout pull/98

Update a local copy of the PR:
$ git checkout pull/98
$ git pull https://git.openjdk.java.net/jdk16u pull/98/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 98

View PR using the GUI difftool:
$ git pr show -t 98

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/98.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8c1112a690480340bb9d69bfaa463b5619829808 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 72be1e2: 8259627: Potential memory leaks in JVMTI after JDK-8227745

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2021
@hseigel
Copy link
Member Author

hseigel commented Mar 31, 2021

/integrate

@openjdk openjdk bot closed this Mar 31, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@hseigel Since your change was applied there has been 1 commit pushed to the master branch:

  • 72be1e2: 8259627: Potential memory leaks in JVMTI after JDK-8227745

Your commit was automatically rebased without conflicts.

Pushed as commit 3464a0f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Mar 31, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant