Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8263311: Watch registry changes for remote printers update instead of polling #99

Closed
wants to merge 1 commit into from
Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Mar 31, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263311: Watch registry changes for remote printers update instead of polling

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk16u pull/99/head:pull/99
$ git checkout pull/99

Update a local copy of the PR:
$ git checkout pull/99
$ git pull https://git.openjdk.java.net/jdk16u pull/99/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 99

View PR using the GUI difftool:
$ git pr show -t 99

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk16u/pull/99.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 31, 2021

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a85dc557b30f5fe8a27b265ff0fd8eba51ed0a73 8263311: Watch registry changes for remote printers update instead of polling Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263311: Watch registry changes for remote printers update instead of polling

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 3464a0f: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed
  • 72be1e2: 8259627: Potential memory leaks in JVMTI after JDK-8227745
  • e99595b: 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die
  • 566703a: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • 484087b: 8258753: StartTlsResponse.close() hangs due to synchronization issues
  • 5375fda: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2021
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Mar 31, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2021
@openjdk
Copy link

openjdk bot commented Mar 31, 2021

@aivanov-jdk Since your change was applied there have been 6 commits pushed to the master branch:

  • 3464a0f: 8261916: gtest/GTestWrapper.java vmErrorTest.unimplemented1_vm_assert failed
  • 72be1e2: 8259627: Potential memory leaks in JVMTI after JDK-8227745
  • e99595b: 8263564: Consolidate POSIX code for runtime exit support: os::shutdown, os::abort and os::die
  • 566703a: 8261262: Kitchensink24HStress.java crashed with EXCEPTION_ACCESS_VIOLATION
  • 484087b: 8258753: StartTlsResponse.close() hangs due to synchronization issues
  • 5375fda: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

Your commit was automatically rebased without conflicts.

Pushed as commit 31940f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the JDK-8263311 branch March 31, 2021 18:32
@mlbridge
Copy link

mlbridge bot commented Mar 31, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant