Skip to content
This repository has been archived by the owner. It is now read-only.

8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs #100

Closed
wants to merge 1 commit into from

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented Jun 18, 2021

Please review this fix to backout the change to Disable SHA-1 Signed JARs from JDK 17 due to a startup performance regression (see https://bugs.openjdk.java.net/browse/JDK-8266971). The plan is to now address the performance issue in JDK 18, which will also allow for more bake time.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Error

 ⚠️ This PR only contains changes already present in the target

Issue

  • JDK-8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/100/head:pull/100
$ git checkout pull/100

Update a local copy of the PR:
$ git checkout pull/100
$ git pull https://git.openjdk.java.net/jdk17 pull/100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 100

View PR using the GUI difftool:
$ git pr show -t 100

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/100.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@seanjmullan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Jun 18, 2021
@seanjmullan seanjmullan changed the title [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs. 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs. Jun 18, 2021
@openjdk openjdk bot added the rfr label Jun 18, 2021
@seanjmullan seanjmullan changed the title 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs. 8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs Jun 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

@seanjmullan
Copy link
Member Author

@seanjmullan seanjmullan commented Jun 18, 2021

/csr

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@seanjmullan the issue for this pull request, JDK-8267100, already has an approved CSR request: JDK-8267268

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@seanjmullan This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added the ready label Jun 18, 2021
@openjdk openjdk bot removed ready rfr labels Jun 24, 2021
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 15, 2021

@seanjmullan Since the fix for this bug was integrated via PR #113 can you close this PR to withdraw it?

@seanjmullan
Copy link
Member Author

@seanjmullan seanjmullan commented Jul 16, 2021

@kevinrushforth Done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
security
3 participants