Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr #101

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jun 18, 2021

Since a stack address can point to a hotspot object, findpc of a stack address should allow for "Is of type..." to be the result, rather than requiring it to be "In java stack". The implementation of findpc checks if the address is a hotspot object before checking if it is the stack, which seems to be what you would want.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/101/head:pull/101
$ git checkout pull/101

Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.java.net/jdk17 pull/101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 101

View PR using the GUI difftool:
$ git pr show -t 101

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/101.diff

@plummercj plummercj closed this Jun 18, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2021

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@plummercj plummercj reopened this Jun 18, 2021
@plummercj plummercj changed the title 8268556: Use bitmap for storing regions that failed evacuation 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr Jun 18, 2021
@openjdk
Copy link

openjdk bot commented Jun 18, 2021

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.java.net rfr Pull request is ready for review labels Jun 18, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2021

Webrevs

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new expression will match the failures that happened yesterday.

Thumbs up! I think this is a trivial fix.

@openjdk
Copy link

openjdk bot commented Jun 18, 2021

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 7e03cf2: 8265073: XML transformation and indentation when using xml:space
  • 60389ee: 8269025: jsig/Testjsig.java doesn't check exit code
  • dab00ee: 8266518: Refactor and expand scatter/gather tests
  • f9c8c1c: 8268903: JFR: RecordingStream::dump is missing @SInCE
  • d8a0582: 8265369: [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed with "SocketException: Cannot allocate memory"
  • 21abcc4: 8268564: mark hotspot serviceability/attach tests which ignore external VM flags
  • f83c6b8: 8268531: mark SDTProbesGNULinuxTest as ignoring external VM flags
  • 8366c69: 8268541: mark hotspot serviceability/sa tests which ignore external VM flags
  • 5b19898: 8268563: mark hotspot serviceability/jvmti tests which ignore external VM flags
  • 2f65d40: 8268599: mark hotspot runtime/sealedClasses tests which ignore external VM flags
  • ... and 48 more: https://git.openjdk.java.net/jdk17/compare/c088d093e2e73fd0739d9e96f9f5ea67a01ae06c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 18, 2021
@plummercj
Copy link
Contributor Author

Thanks Dan!

@plummercj
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 18, 2021

Going to push as commit 8caeca0.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 7e03cf2: 8265073: XML transformation and indentation when using xml:space
  • 60389ee: 8269025: jsig/Testjsig.java doesn't check exit code
  • dab00ee: 8266518: Refactor and expand scatter/gather tests
  • f9c8c1c: 8268903: JFR: RecordingStream::dump is missing @SInCE
  • d8a0582: 8265369: [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed with "SocketException: Cannot allocate memory"
  • 21abcc4: 8268564: mark hotspot serviceability/attach tests which ignore external VM flags
  • f83c6b8: 8268531: mark SDTProbesGNULinuxTest as ignoring external VM flags
  • 8366c69: 8268541: mark hotspot serviceability/sa tests which ignore external VM flags
  • 5b19898: 8268563: mark hotspot serviceability/jvmti tests which ignore external VM flags
  • 2f65d40: 8268599: mark hotspot runtime/sealedClasses tests which ignore external VM flags
  • ... and 48 more: https://git.openjdk.java.net/jdk17/compare/c088d093e2e73fd0739d9e96f9f5ea67a01ae06c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 18, 2021
@openjdk
Copy link

openjdk bot commented Jun 18, 2021

@plummercj Pushed as commit 8caeca0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.java.net
2 participants