Skip to content
This repository has been archived by the owner. It is now read-only.

8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header #102

Closed

Conversation

bulasevich
Copy link
Contributor

@bulasevich bulasevich commented Jun 18, 2021

Hi,

Could we have a review of this change?

The bug was discovered in ARM32 C1 monitor locking/unlocking: the
displaced header is not initialized to the non-zero value which results in deadlock.

The issue was fixed in jdk18, and I want to have this P3 fix in jdk17 as well.

Thanks,
Boris


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header ⚠️ Issue is not open.

Reviewers

Contributors

  • Chris Cole <chris@sageembedded.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/102/head:pull/102
$ git checkout pull/102

Update a local copy of the PR:
$ git checkout pull/102
$ git pull https://git.openjdk.java.net/jdk17 pull/102/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 102

View PR using the GUI difftool:
$ git pr show -t 102

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/102.diff

@bulasevich
Copy link
Contributor Author

@bulasevich bulasevich commented Jun 18, 2021

/contributor add Chris Cole chris@sageembedded.com

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@bulasevich Could not parse Chris Cole chris@sageembedded.com as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@bulasevich The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Jun 18, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

@bulasevich
Copy link
Contributor Author

@bulasevich bulasevich commented Jun 20, 2021

/contributor add Chris Cole chris@sageembedded.com

@openjdk
Copy link

@openjdk openjdk bot commented Jun 20, 2021

@bulasevich
Contributor Chris Cole <chris@sageembedded.com> successfully added.

@bulasevich bulasevich changed the title 8269035: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header

Co-authored-by: Chris Cole <chris@sageembedded.com>
Reviewed-by: dsamersoff

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b358b54: 8269063: Build failure due to VerifyReceiverTypes was not declared after JDK-8268405
  • b8f073b: 8268316: Typo in JFR jdk.Deserialization event
  • b9d7337: 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting.
  • 8caeca0: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 21, 2021
@bulasevich
Copy link
Contributor Author

@bulasevich bulasevich commented Jun 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

Going to push as commit c294ae4.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b358b54: 8269063: Build failure due to VerifyReceiverTypes was not declared after JDK-8268405
  • b8f073b: 8268316: Typo in JFR jdk.Deserialization event
  • b9d7337: 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting.
  • 8caeca0: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@bulasevich Pushed as commit c294ae4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot-compiler integrated
2 participants