-
Notifications
You must be signed in to change notification settings - Fork 148
8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion #109
Conversation
👋 Welcome back roland! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. We have to re-approve when PR is moved it to JDK 17.
@rwestrel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/reviewer credit neliasso |
@rwestrel |
@vnkozlov thanks for re-reviewing |
/integrate |
Going to push as commit 578c55b.
Your commit was automatically rebased without conflicts. |
Already reviewed under openjdk/jdk#4388
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/109/head:pull/109
$ git checkout pull/109
Update a local copy of the PR:
$ git checkout pull/109
$ git pull https://git.openjdk.java.net/jdk17 pull/109/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 109
View PR using the GUI difftool:
$ git pr show -t 109
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/109.diff