8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails

[DamonFool]

Hi all,

jdk/jfr/event/gc/collection/TestSystemGc.java fails in jdk17 and jdk.

It can be fixed by renaming :
test/jdk/jdk/jfr/event/gc/collection/TestSystemGc.java -> test/jdk/jdk/jfr/event/gc/collection/TestSystemGC.java

Thanks.
Best regards,
Jie

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails

Reviewers

• Erik Gahlin (@egahlin - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.java.net/jdk17 pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/11.diff

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d79d3ddf)

[DamonFool]

/test

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268576: jdk/jfr/event/gc/collection/TestSystemGc.java fails

Reviewed-by: egahlin, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonFool]

Thanks @egahlin for your review.

Do you think it's trivial and can be pushed right now? @egahlin
Thanks.

[dholmes-ora]

Thanks for fixing Jie!

David

[DamonFool]

Thanks for fixing Jie!

David

Thanks @dholmes-ora .
Will push it soon.

[dholmes-ora]

Note this will fix the problem in JDK 18 not JDK 17. If you push to 18 you will need a manual backport to 17. If you push to 17 it will be automatically forweard-ported to 18.

[DamonFool]

Note this will fix the problem in JDK 18 not JDK 17. If you push to 18 you will need a manual backport to 17. If you push to 17 it will be automatically forweard-ported to 18.

This PR is in JDK17.
So I think it should go into JDK 17, right?

[dholmes-ora]

Right. Sorry I didn't see the "17" only the openjdk:master :)

[DamonFool]

/integrate

[openjdk]

Going to push as commit e3eef3b.

[openjdk]

@DamonFool Pushed as commit e3eef3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.