Skip to content
This repository has been archived by the owner. It is now read-only.

8267752: KVHashtable doesn't deallocate entries #110

Closed
wants to merge 1 commit into from

Conversation

@navyxliu
Copy link
Contributor

@navyxliu navyxliu commented Jun 21, 2021

Add a free_entry iteration to the destructor of ~KVHashtables.
Tested with tier1-3.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/110/head:pull/110
$ git checkout pull/110

Update a local copy of the PR:
$ git checkout pull/110
$ git pull https://git.openjdk.java.net/jdk17 pull/110/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 110

View PR using the GUI difftool:
$ git pr show -t 110

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/110.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 21, 2021

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 72b3b0af08136342e54e1cdea0c48d64172e8870 8267752: KVHashtable doesn't deallocate entries Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@navyxliu The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267752: KVHashtable doesn't deallocate entries

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 21, 2021

Webrevs

Loading

@navyxliu
Copy link
Contributor Author

@navyxliu navyxliu commented Jun 21, 2021

hi, @coleenp

JDK-8269064 depends on this JDK-8267752. I think JDK-8267752 itself is also worthy in jdk17.

ctx:
openjdk/jdk#4537 (comment)

Could you take a look at it?

Loading

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 21, 2021

As a P4 bug this is not permitted in JDK 17 under RDP1. You would need to change to a P3 with suitable justification.

Loading

@navyxliu
Copy link
Contributor Author

@navyxliu navyxliu commented Jun 22, 2021

I have consulted Coleen on JBS if there's any risk to bring her patch to jdk17.
Meanwhile, I split JDK-8269064 into the urgent(#121) one and not so urgent one. The later depends on this PR.

Loading

@navyxliu
Copy link
Contributor Author

@navyxliu navyxliu commented Jun 22, 2021

Close this PR because JDK-8267752 is P4, which doesn't fit for the RDP1.

Loading

@navyxliu navyxliu closed this Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants