Skip to content
This repository has been archived by the owner. It is now read-only.

8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs #113

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Jun 21, 2021

This is a copy of #100 so that I can integrate the fix for @seanjmullan.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs ⚠️ Issue is not open.

Reviewers

Contributors

  • Sean Mullan <mullan@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/113/head:pull/113
$ git checkout pull/113

Update a local copy of the PR:
$ git checkout pull/113
$ git pull https://git.openjdk.java.net/jdk17 pull/113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 113

View PR using the GUI difftool:
$ git pr show -t 113

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/113.diff

@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jun 21, 2021

/contributor add @seanjmullan

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 21, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@wangweij
Contributor Sean Mullan <mullan@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Jun 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 21, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267100: [BACKOUT] JDK-8196415 Disable SHA-1 Signed JARs

Co-authored-by: Sean Mullan <mullan@openjdk.org>
Reviewed-by: hchao, xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • d3ad8cd: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • f25e719: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails
  • 22ebd19: 8268362: [REDO] C2 crash when compile negative Arrays.copyOf length after loop
  • f8df953: 8268702: JFR diagnostic commands lack argument descriptors when viewed using Platform MBean Server
  • c294ae4: 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header
  • b358b54: 8269063: Build failure due to VerifyReceiverTypes was not declared after JDK-8268405
  • b8f073b: 8268316: Typo in JFR jdk.Deserialization event
  • b9d7337: 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting.
  • 8caeca0: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • 7e03cf2: 8265073: XML transformation and indentation when using xml:space
  • ... and 3 more: https://git.openjdk.java.net/jdk17/compare/d8a0582a36340bcc65910f3a34132ec6e04e5d01...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 22, 2021
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Jun 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

Going to push as commit e2d7ec3.
Since your change was applied there have been 13 commits pushed to the master branch:

  • d3ad8cd: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • f25e719: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails
  • 22ebd19: 8268362: [REDO] C2 crash when compile negative Arrays.copyOf length after loop
  • f8df953: 8268702: JFR diagnostic commands lack argument descriptors when viewed using Platform MBean Server
  • c294ae4: 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header
  • b358b54: 8269063: Build failure due to VerifyReceiverTypes was not declared after JDK-8268405
  • b8f073b: 8268316: Typo in JFR jdk.Deserialization event
  • b9d7337: 8268638: semaphores of AsyncLogWriter may be broken when JVM is exiting.
  • 8caeca0: 8264775: ClhsdbFindPC still fails with java.lang.RuntimeException: 'In java stack' missing from stdout/stderr
  • 7e03cf2: 8265073: XML transformation and indentation when using xml:space
  • ... and 3 more: https://git.openjdk.java.net/jdk17/compare/d8a0582a36340bcc65910f3a34132ec6e04e5d01...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@wangweij Pushed as commit e2d7ec3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated security
4 participants