Skip to content
This repository has been archived by the owner. It is now read-only.

8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy" #122

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Jun 22, 2021

Looks like another "Resource busy" issue similar to recent fixes for "hdiutil convert" and "hdiutil detach". Workaround in same way by repeating "create" command. Modified RetryExecutor to pass write to file flag, otherwise "hdiutil create" might deadlock.
Also, repeat is done only for creating DMG using size instead of creating from app image. In some cases create DMG from app image might run for very long time and eventually fail, this is why fallback to create DMG from size was added.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/122/head:pull/122
$ git checkout pull/122

Update a local copy of the PR:
$ git checkout pull/122
$ git pull https://git.openjdk.java.net/jdk17 pull/122/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 122

View PR using the GUI difftool:
$ git pr show -t 122

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/122.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the core-libs label Jun 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269036: tools/jpackage/share/AppImagePackageTest.java failed with "hdiutil: create failed - Resource busy"

Reviewed-by: asemenyuk, herrick

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 4eb3212: 8268871: Adjust javac to updated exhaustiveness specification
  • 44691cc: 8268972: Add default impl for recent new Reporter.print method
  • 7ab1285: 8267610: NPE at at jdk.compiler/com.sun.tools.javac.jvm.Code.emitop
  • cfa6a99: 8269316: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Linux-X64 -Xcomp
  • 22d8675: 8269315: ProblemList javax/swing/JFileChooser/FileSystemView/SystemIconTest.java on Win-X64
  • 443a79a: 8269314: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Win-X64 and linux-aarch64
  • 424cc50: 8269307: ProblemList java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java on win-x64
  • 63bcd33: 8269246: Scoped ByteBuffer vector access
  • 3fb28d3: 8269218: GaloisCounterMode.overlapDetection misses the JDK-8263436 fix again
  • d3d3b22: 8269265: ProblemList serviceability/sa/TestJmapCoreMetaspace.java with ZGC
  • ... and 26 more: https://git.openjdk.java.net/jdk17/compare/b8f073be84b6bf2f83e2a65d20b7eb8c03120dce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 23, 2021
@victordyakov
Copy link
Contributor

@victordyakov victordyakov commented Jun 25, 2021

@andyherrick please review

Loading

@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Jun 25, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

Going to push as commit fb0a95f.
Since your change was applied there have been 39 commits pushed to the master branch:

  • 5ebed06: 8269074: (fs) Files.copy fails to copy from /proc on some linux kernel versions
  • d799563: 8256919: BCEL: Utility.encode forget to close
  • 1e3b418: 8269335: Unable to load svml library
  • 4eb3212: 8268871: Adjust javac to updated exhaustiveness specification
  • 44691cc: 8268972: Add default impl for recent new Reporter.print method
  • 7ab1285: 8267610: NPE at at jdk.compiler/com.sun.tools.javac.jvm.Code.emitop
  • cfa6a99: 8269316: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Linux-X64 -Xcomp
  • 22d8675: 8269315: ProblemList javax/swing/JFileChooser/FileSystemView/SystemIconTest.java on Win-X64
  • 443a79a: 8269314: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on Win-X64 and linux-aarch64
  • 424cc50: 8269307: ProblemList java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java on win-x64
  • ... and 29 more: https://git.openjdk.java.net/jdk17/compare/b8f073be84b6bf2f83e2a65d20b7eb8c03120dce...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

@sashamatveev Pushed as commit fb0a95f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants