Skip to content
This repository has been archived by the owner. It is now read-only.

8269218: GaloisCounterMode.overlapDetection misses the JDK-8263436 fix again #124

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jun 23, 2021

SonarCloud again complains about GaloisCounterMode.overlapDetection, in the similar way JDK-8263436 did. I think JDK-8255557 accidentally reintroduced the old code.

The tangential question if JDK-8255557 reverted anything else.

Additional testing:

  • jdk_security passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269218: GaloisCounterMode.overlapDetection misses the JDK-8263436 fix again

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/124/head:pull/124
$ git checkout pull/124

Update a local copy of the PR:
$ git checkout pull/124
$ git pull https://git.openjdk.java.net/jdk17 pull/124/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 124

View PR using the GUI difftool:
$ git pr show -t 124

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/124.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@shipilev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label Jun 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 23, 2021

Webrevs

Loading

Copy link
Contributor

@ascarpino ascarpino left a comment

Yes, that got let back in after a merge

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269218: GaloisCounterMode.overlapDetection misses the JDK-8263436 fix again

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 1b2147a: 8269125: Klass enqueue element size calculation wrong when traceid value cross compress limit
  • bf70620: 8268961: Parenthesized pattern with guards does not work
  • 8128ca1: 8269066: assert(ZAddress::is_marked(addr)) failed: Should be marked
  • 1323be5: 8269064: Dropped messages of AsyncLogWriter cause memleak

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 23, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jun 24, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

Going to push as commit 3fb28d3.
Since your change was applied there have been 9 commits pushed to the master branch:

  • d3d3b22: 8269265: ProblemList serviceability/sa/TestJmapCoreMetaspace.java with ZGC
  • 0c3fc27: 8268482: compiler/intrinsics/VectorizedMismatchTest.java failed with failed: length in range
  • a30141d: 8269179: Crash in TestMacroLogicVector::testSubWordBoolean: assert(_base >= VectorMask && _base <= VectorZ) failed: Not a Vector
  • b474314: 8266854: LibraryCallKit::inline_preconditions_checkIndex modifies control flow even if the intrinsic bailed out
  • 7e96318: 8254571: Erroneous generic type inference in a lambda expression with a checked exception
  • 1b2147a: 8269125: Klass enqueue element size calculation wrong when traceid value cross compress limit
  • bf70620: 8268961: Parenthesized pattern with guards does not work
  • 8128ca1: 8269066: assert(ZAddress::is_marked(addr)) failed: Should be marked
  • 1323be5: 8269064: Dropped messages of AsyncLogWriter cause memleak

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@shipilev Pushed as commit 3fb28d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8269218-gcm-reverted branch Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants