-
Notifications
You must be signed in to change notification settings - Fork 155
8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC #132
8269126: Rename G1AllowPreventiveGC option to G1UsePreventiveGC #132
Conversation
|
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
kimbarrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Thanks @kimbarrett @walulyai for your reviews. |
|
Going to push as commit fc0fd96.
Your commit was automatically rebased without conflicts. |
Hi all,
can I have reviews for this change that as the title suggest only changes the name of the
G1AllowPreventiveGCoption toG1UsePreventiveGCto better conform to other G1 options which all useUseas prefix (jdk17 version).Since this is a diagnostic flag, no further process is required.
Testing: tier1-5
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/132/head:pull/132$ git checkout pull/132Update a local copy of the PR:
$ git checkout pull/132$ git pull https://git.openjdk.java.net/jdk17 pull/132/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 132View PR using the GUI difftool:
$ git pr show -t 132Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/132.diff