Skip to content
This repository has been archived by the owner. It is now read-only.

8265907: JVM crashes when matching VectorMaskCmp Node #134

Closed

Conversation

@Wanghuang-Huawei
Copy link

@Wanghuang-Huawei Wanghuang-Huawei commented Jun 24, 2021

  • fix the issue JDK-8265907
  • all archs might be effected by this bug. I fixed x86 and aarch64.
  • merged from openjdk/jdk#3670

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265907: JVM crashes when matching VectorMaskCmp Node

Reviewers

Contributors

  • Wang Huang <whuang@openjdk.org>
  • Ai Jiaming <aijiaming1@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.java.net/jdk17 pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/134.diff

@Wanghuang-Huawei
Copy link
Author

@Wanghuang-Huawei Wanghuang-Huawei commented Jun 24, 2021

/contributor add Wang Huang whuang@openjdk.org
/contributor add Ai Jiaming aijiaming1@huawei.com

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2021

👋 Welcome back whuang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 24, 2021
@Wanghuang-Huawei
Copy link
Author

@Wanghuang-Huawei Wanghuang-Huawei commented Jun 24, 2021

@sviswa7 @PaulSandoz @nsjian @jatin-bhateja @mgkwill @XiaohongGong , Please do me a favor to review this patch. Thank you very much.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@Wanghuang-Huawei
Contributor Wang Huang <whuang@openjdk.org> successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@Wanghuang-Huawei
Contributor Ai Jiaming <aijiaming1@huawei.com> successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@Wanghuang-Huawei The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2021

Webrevs

Loading

nsjian
nsjian approved these changes Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

@Wanghuang-Huawei This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265907: JVM crashes when matching VectorMaskCmp Node

Co-authored-by: Wang Huang <whuang@openjdk.org>
Co-authored-by: Ai Jiaming <aijiaming1@huawei.com>
Reviewed-by: njian, jbhateja, sviswanathan, dlong, adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • c3c9189: 8269141: Switch statement containing pattern case label element gets in the loop during execution
  • 6b64a79: 8268350: Remove assert that ensures thread identifier remains the same
  • 90eb118: 8269528: VectorAPI Long512VectorTest fails on X86 KNL target
  • a661686: 8269065: [REDO] vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
  • 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
  • d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
  • 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
  • b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
  • 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
  • 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127
  • ... and 26 more: https://git.openjdk.java.net/jdk17/compare/d3d3b221d3ae8de21c42749f48343fe2d49cdeee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian, @jatin-bhateja, @sviswa7, @dean-long, @adinn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Jun 25, 2021
@Wanghuang-Huawei
Copy link
Author

@Wanghuang-Huawei Wanghuang-Huawei commented Jun 30, 2021

@adinn Can you do me a favor to review this patch? Thank you very much.

Loading

Copy link
Member

@dean-long dean-long left a comment

Seems OK to me.

Loading

adinn
adinn approved these changes Jun 30, 2021
Copy link
Contributor

@adinn adinn left a comment

Looks ok, including AArch64 changes.
I am happy to sponsor this once you integrate it.

Loading

@Wanghuang-Huawei
Copy link
Author

@Wanghuang-Huawei Wanghuang-Huawei commented Jun 30, 2021

Thank you all.

Loading

@Wanghuang-Huawei
Copy link
Author

@Wanghuang-Huawei Wanghuang-Huawei commented Jun 30, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@Wanghuang-Huawei
Your change (at version 940dfee) is now ready to be sponsored by a Committer.

Loading

@adinn
Copy link
Contributor

@adinn adinn commented Jun 30, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

Going to push as commit ca283c3.
Since your change was applied there have been 36 commits pushed to the master branch:

  • c3c9189: 8269141: Switch statement containing pattern case label element gets in the loop during execution
  • 6b64a79: 8268350: Remove assert that ensures thread identifier remains the same
  • 90eb118: 8269528: VectorAPI Long512VectorTest fails on X86 KNL target
  • a661686: 8269065: [REDO] vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
  • 0d745ae: 8269034: AccessControlException for SunPKCS11 daemon threads
  • d042029: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
  • 401cb0a: 8269232: assert(!is_jweak(handle)) failed: wrong method for detroying jweak
  • b8a16e9: 8268884: C2: Compile::remove_speculative_types must iterate top-down
  • 25f9f19: 8249646: Runtime.exec(String, String[], File) documentation contains literal {@link ...}
  • 0d83dc2: 8268699: Shenandoah: Add test for JDK-8268127
  • ... and 26 more: https://git.openjdk.java.net/jdk17/compare/d3d3b221d3ae8de21c42749f48343fe2d49cdeee...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@adinn @Wanghuang-Huawei Pushed as commit ca283c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.