-
Notifications
You must be signed in to change notification settings - Fork 144
8265907: JVM crashes when matching VectorMaskCmp Node #134
Conversation
/contributor add Wang Huang whuang@openjdk.org |
👋 Welcome back whuang! A progress list of the required criteria for merging this PR into |
@sviswa7 @PaulSandoz @nsjian @jatin-bhateja @mgkwill @XiaohongGong , Please do me a favor to review this patch. Thank you very much. |
@Wanghuang-Huawei |
@Wanghuang-Huawei |
@Wanghuang-Huawei The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@Wanghuang-Huawei This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@nsjian, @jatin-bhateja, @sviswa7, @dean-long, @adinn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@adinn Can you do me a favor to review this patch? Thank you very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, including AArch64 changes.
I am happy to sponsor this once you integrate it.
Thank you all. |
/integrate |
@Wanghuang-Huawei |
/sponsor |
Going to push as commit ca283c3.
Your commit was automatically rebased without conflicts. |
@adinn @Wanghuang-Huawei Pushed as commit ca283c3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Progress
Issue
Reviewers
Contributors
<whuang@openjdk.org>
<aijiaming1@huawei.com>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17 pull/134/head:pull/134
$ git checkout pull/134
Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.java.net/jdk17 pull/134/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 134
View PR using the GUI difftool:
$ git pr show -t 134
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17/pull/134.diff